(control) Disable the start button for actors that aren't directly initializable.

(control) Disable the start button for actors that aren't directly initializable.

code/common/message-queue/src/main/java/nu/marginalia/mqsm/StateMachine.java

@@ -42,6 +42,7 @@ public class StateMachine {
     private final List<BiConsumer<String, String>> stateChangeListeners = new ArrayList<>();
     private final Map<String, MachineState> allStates = new HashMap<>();
 
+    private final boolean isDirectlyInitializable;
 
     public StateMachine(MessageQueueFactory messageQueueFactory,
                         String queueName,
@@ -57,6 +58,7 @@ public class StateMachine {
 
         registerStates(List.of(errorState, finalState, resumingState));
         registerStates(stateGraph);
+        isDirectlyInitializable = stateGraph.isDirectlyInitializable();
 
         for (var declaredState : stateGraph.declaredStates()) {
             if (!allStates.containsKey(declaredState.name())) {
@@ -339,6 +341,11 @@ public class StateMachine {
         smInbox.abortCurrentTask();
     }
 
+    /** Returns true if there is an INITIAL state that requires no parameters */
+    public boolean isDirectlyInitializable() {
+        return isDirectlyInitializable;
+    }
+
     private class StateEventSubscription implements MqSubscription {
 
         @Override

code/common/message-queue/src/main/java/nu/marginalia/mqsm/graph/AbstractStateGraph.java

@@ -39,6 +39,21 @@ public abstract class AbstractStateGraph {
         throw new ControlFlowException("ERROR", ex.getClass().getSimpleName() + ":" + ex.getMessage());
     }
 
+    /** Check whether there is an INITIAL state that can be directly initialized
+     * without declared parameters. */
+    public boolean isDirectlyInitializable() {
+        for (var method : getClass().getMethods()) {
+            var gs = method.getAnnotation(GraphState.class);
+            if (gs == null) {
+                continue;
+            }
+            if ("INITIAL".equals(gs.name()) && method.getParameterCount() == 0) {
+                return true;
+            }
+        }
+        return false;
+    }
+
     public Set<GraphState> declaredStates() {
         Set<GraphState> ret = new HashSet<>();
 

code/services-satellite/control-service/src/main/java/nu/marginalia/control/actor/ControlActors.java

@@ -112,6 +112,10 @@ public class ControlActors {
         );
     }
 
+    public boolean isDirectlyInitializable(Actor actor) {
+        return actorDefinitions.get(actor).isDirectlyInitializable();
+    }
+
     public AbstractStateGraph getActorDefinition(Actor actor) {
         return actorDefinitions.get(actor);
     }

code/services-satellite/control-service/src/main/java/nu/marginalia/control/model/ActorRunState.java

@@ -1,6 +1,6 @@
 package nu.marginalia.control.model;
 
-public record ActorRunState(String name, String state, boolean terminal) {
+public record ActorRunState(String name, String state, boolean terminal, boolean canStart) {
     public String stateIcon() {
         if (terminal) {
             return "\uD83D\uDE34";

code/services-satellite/control-service/src/main/java/nu/marginalia/control/svc/ControlActorService.java

@@ -90,8 +90,9 @@ public class ControlActorService {
             final String machineName = e.getKey().name();
             final String stateName = state.name();
             final boolean terminal = state.isFinal();
+            final boolean canStart = controlActors.isDirectlyInitializable(e.getKey()) && terminal;
 
-            return new ActorRunState(machineName, stateName, terminal);
+            return new ActorRunState(machineName, stateName, terminal, canStart);
         }).toList();
     }
 

code/services-satellite/control-service/src/main/resources/templates/control/partials/actors-table.hdb

@@ -23,7 +23,19 @@
                     action="/fsms/{{name}}/start"
                     method="post"
                     onsubmit="return toggleActorSwitch('{{name}}')">
-                    <input type="submit" value="Off" class="toggle-switch-off" id="toggle-{{name}}-button">
+                    <input
+                        type="submit"
+                        {{#unless canStart}}
+                        disabled
+                        value="Stop"
+                        title="This actor cannot be started here"
+                        {{/unless}}
+                        {{#if canStart}}
+                        value="Off"
+                        {{/if}}
+                        class="toggle-switch-off"
+
+                        id="toggle-{{name}}-button">
                 </form>
             {{/if}}