161sh/CatgirlIntelligenceAgency
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

(minor) Improve error handling, naming logging in IndexResultDecorator

Browse Source
This commit is contained in:
Viktor Lofgren 2024-02-05 21:05:44 +01:00
parent 6e7649b5f7
commit eadcdb5bed
1 changed files with 21 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

35
code/services-core/index-service/src/main/java/nu/marginalia/index/results/IndexResultDecorator.java
View File

@ -53,30 +53,37 @@ public class IndexResultDecorator {
List<DecoratedSearchResultItem> decoratedItems = new ArrayList<>();
for (var result : rawResults) {
var linkData = urlDetailsById.get(result.getDocumentId());
decoratedItems.add(createCombinedItem(result, linkData, rankingContext));
var docData = urlDetailsById.get(result.getDocumentId());
if (null == docData) {
logger.warn("No data for document id {}", result.getDocumentId());
continue;
}
decoratedItems.add(createCombinedItem(result, docData, rankingContext));
}
assert decoratedItems.size() == rawResults.size() : "Result list shrunk during decoration?";
if (decoratedItems.size() != rawResults.size())
logger.warn("Result list shrunk during decoration?");
return decoratedItems;
}
private DecoratedSearchResultItem createCombinedItem(SearchResultItem result,
DocdbUrlDetail linkData,
DocdbUrlDetail docData,
ResultRankingContext rankingContext) {
return new DecoratedSearchResultItem(
result,
linkData.url(),
linkData.title(),
linkData.description(),
linkData.urlQuality(),
linkData.format(),
linkData.features(),
linkData.pubYear(),
linkData.dataHash(),
linkData.wordsTotal(),
valuator.calculateSearchResultValue(result.keywordScores, linkData.wordsTotal(), rankingContext)
docData.url(),
docData.title(),
docData.description(),
docData.urlQuality(),
docData.format(),
docData.features(),
docData.pubYear(),
docData.dataHash(),
docData.wordsTotal(),
valuator.calculateSearchResultValue(result.keywordScores, docData.wordsTotal(), rankingContext)
);
}