161sh/CatgirlIntelligenceAgency
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

(api) Clean up incorrect error handling in GrpcChannelPool

Browse Source
This commit is contained in:
Viktor Lofgren 2024-02-18 08:45:35 +01:00
parent 296ccc5f8e
commit f9b6ac03c6
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
code/common/service-client/src/main/java/nu/marginalia/client/grpc/GrpcChannelPool.java
View File

@ -44,9 +44,16 @@ public abstract class GrpcChannelPool<STUB> {
}
private ManagedChannel refreshChannel(ServiceAndNode serviceAndNode, ManagedChannel old) {
if (old == null || old.getState(true) != SHUTDOWN) {
if (old == null)
return createChannel(serviceAndNode);
// If the channel is in SHUTDOWN state, we need to create a new one
// (shouldn't really happen in practice, but it's a good idea to be safe)
if (old.getState(true) == SHUTDOWN) {
old.shutdown();
return createChannel(serviceAndNode);
}
return old;
}