Commit Graph

8 Commits

Author SHA1 Message Date
syuilo
7cf2bdac7f perf(client): use shallowRef as possible 2022-08-06 19:20:53 +09:00
syuilo
4e20f39dca refactor(client): extract interval logic to a composable function
あと`onUnmounted`を`onMounted`内で呼んでいたりしたのを修正したりとか
2022-06-26 03:12:58 +09:00
Johann150
ec47b46423 refactor: improve code quality (#8751)
* remove unnecessary if

`Array.prototype.some` already returns a boolean so an if to return
true or false is completely unnecessary in this case.

* perf: use count instead of find

When using `count` instead of `findOneBy`, the data is not
unnecessarily loaded.

* remove duplicate null check

The variable is checked for null in the lines above and the function
returns if so. Therefore, it can not be null at this point.

* simplify `getJsonSchema`

Because the assigned value is `null` and the used keys are only
shallow, use of `nestedProperty.set` seems inappropriate. Because the
value is not read, the initial for loop can be replaced by a `for..in`
loop.

Since all keys will be assigned `null`, the condition of the ternary
expression in the nested function will always be true. Therefore the
recursion case will never happen. With this the nested function can be
eliminated.

* remove duplicate condition

The code above already checks `dragging` and returns if it is truthy.
Checking it again later is therefore unnecessary.

To make this more obvious the `return` is removed in favour of using
an if...else construct.

* remove impossible "unknown" time

The `ago` variable will always be a number and all non-negative numbers
are already covered by other cases, the negative case is handled with
`future` so there is no case when `unkown` could be achieved.
2022-05-29 15:15:52 +09:00
Johann150
d2ca085a17 fix lints (#8737)
* fix: emits use ev instead of e

* fix: errors use err instead of e

* fix: replace use of data where possible

* fix: events use evt instead of e

* fix: use strict equals

* fix: use emoji instead of e

* fix: vue lints
2022-05-26 22:53:09 +09:00
Johann150
07ab5d181b round relative time (#8199) 2022-01-28 15:29:24 +09:00
syuilo
0f57ea08e7 refactor(client): i18n.locale -> i18n.ts 2022-01-28 11:39:49 +09:00
syuilo
52c13e9db5 wip: refactor(client): migrate components to composition api 2022-01-16 07:47:28 +09:00
syuilo
14148f6c4a refactoring
Resolve #7779
2021-11-12 02:02:25 +09:00